Skip to content

Conversation

@hughescoin
Copy link
Contributor

What changed? Why?
Only reference ownerAddress instead of allowedAddresses as it is the preferred method for adding app owner in Base Build

Notes to reviewers

How has it been tested?

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 24, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Collaborator

@soheimam soheimam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have one more manifest example to update.

@soheimam soheimam merged commit 55c28c7 into master Oct 24, 2025
8 checks passed
@soheimam soheimam deleted the pat/manifest-owneraddr branch October 24, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants