Skip to content

Conversation

@danyalprout
Copy link
Collaborator

Description

We broke the docker builds (fixed in #128), we should check this in CI

Copy link
Contributor

@haardikk21 haardikk21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but alternatively can get rid of this dockerfile too since we dont use it. We use the one in base/node

@danyalprout danyalprout marked this pull request as ready for review October 10, 2025 13:59
@danyalprout
Copy link
Collaborator Author

My thinking is base/node contains Base specific releases (and configs), we should keep this dockerfile and packages in this repo that can be shared by other teams using the ExExs

@danyalprout danyalprout merged commit 0717f6c into main Oct 10, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Project Tracking Oct 10, 2025
@danyalprout danyalprout deleted the docker-builds branch October 10, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants