feat: extend validate_bundle criteria
#35
Merged
+165
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlawt
force-pushed
the
validation-criteria
branch
from
8701420 to
3e92994
Compare
niran
reviewed
Oct 23, 2025
| /// - The bundle's max_timestamp is not more than 1 hour in the future | ||
| /// - The bundle's gas limit is not greater than the maximum allowed gas limit | ||
| pub fn validate_bundle(bundle: &EthSendBundle, bundle_gas: u64) -> RpcResult<()> { | ||
| /// - The bundle can only contain 3 transactions at once |
There was a problem hiding this comment.
https://github.com/base/tips/blob/master/docs/API.md#eth_sendbundleethsendbundle---uuid
Can only provide three transactions at once
niran
reviewed
Oct 23, 2025
wlawt
force-pushed
the
validation-criteria
branch
from
cf6711a to
155ba20
Compare
danyalprout
reviewed
Oct 27, 2025
wlawt
force-pushed
the
validation-criteria
branch
from
155ba20 to
8aa0598
Compare
danyalprout
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR aligns the validate_bundle fn with the limitations set in the API spec. More ongoing thought will be going into what more criteria do we want in validating bundles. But for now, this is fine.
Tests