Skip to content

chore: have multiple builders listen to channel for MeterBundleResponse #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

chore: have multiple builders listen to channel for MeterBundleResponse #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ TIPS_INGRESS_METRICS_ADDR=0.0.0.0:9002
TIPS_INGRESS_BLOCK_TIME_MILLISECONDS=2000
TIPS_INGRESS_METER_BUNDLE_TIMEOUT_MS=2000
TIPS_INGRESS_MAX_BUFFERED_METER_BUNDLE_RESPONSES=100
TIPS_INGRESS_BUILDER_RPC=http://localhost:2222
TIPS_INGRESS_BUILDER_RPCS=http://localhost:2222

# Audit service configuration
TIPS_AUDIT_KAFKA_PROPERTIES_FILE=/app/docker/audit-kafka-properties
Expand Down
9 changes: 5 additions & 4 deletions crates/ingress-rpc/src/bin/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,12 @@ async fn main() -> anyhow::Result<()> {
let (audit_tx, audit_rx) = mpsc::unbounded_channel::<BundleEvent>();
connect_audit_to_publisher(audit_rx, audit_publisher);

// TODO: when we have multiple builders we can make `builder_rx` mutable and do `.subscribe()` to have multiple consumers
// of this channel.
let (builder_tx, builder_rx) =
let (builder_tx, _) =
broadcast::channel::<MeterBundleResponse>(config.max_buffered_meter_bundle_responses);
connect_ingress_to_builder(builder_rx, config.builder_rpc);
config.builder_rpcs.iter().for_each(|builder_rpc| {
let builder_rx = builder_tx.subscribe();
connect_ingress_to_builder(builder_rx, builder_rpc.clone());
});

let service = IngressService::new(
provider,
Expand Down
6 changes: 3 additions & 3 deletions crates/ingress-rpc/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,9 @@ pub struct Config {
)]
pub meter_bundle_timeout_ms: u64,

/// URL of the builder RPC service for setting metering information
#[arg(long, env = "TIPS_INGRESS_BUILDER_RPC")]
pub builder_rpc: Url,
/// URLs of the builder RPC service for setting metering information
#[arg(long, env = "TIPS_INGRESS_BUILDER_RPCS")]
pub builder_rpcs: Vec<Url>,

/// Maximum number of `MeterBundleResponse`s to buffer in memory
#[arg(
Expand Down