Skip to content

Conversation

@youssefea
Copy link
Contributor

What changed? Why?

Smart wallet Quickstart had a few typos related to the estimated durations of the integration guides

This PR is to fix these differences

Tested

BaseDocs

  • docs.base.org
  • docs sub-pages

@vercel
Copy link

vercel bot commented Mar 28, 2025

@youssefea is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 28, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 2:15pm
web-base-docs ❌ Failed (Inspect) May 6, 2025 2:15pm

@wbnns
Copy link
Contributor

wbnns commented Mar 28, 2025

@youssefea Can you please update to fix the merge conflicts?

@wbnns wbnns added the change(s) requested One or more changes have been requested label Mar 28, 2025
@cb-heimdall
Copy link
Collaborator

Review Error for wbnns @ 2025-03-28 21:21:02 UTC
User failed mfa authentication, see go/mfa-help

@youssefea
Copy link
Contributor Author

@youssefea Can you please update to fix the merge conflicts?

Resolved

@youssefea youssefea enabled auto-merge (squash) May 6, 2025 13:49
@youssefea youssefea merged commit 76bff2f into base:master May 7, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base docs review To be reviewed by the Base docs team change(s) requested One or more changes have been requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants