Skip to content

Conversation

@digichi
Copy link
Contributor

@digichi digichi commented Mar 30, 2025

-Context structure change from "ex. " to "e.g.,"
-Grammar in "additional context"

What changed? Why?
"ex." to "e.g.,"
"E.g." means for example, you use "e.g.," to introduce examples of something.
while
"Ex." is short for "exercise.", "ex." is used to introduce exercises.

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

BaseDocs

  • [] docs.base.org
  • [] docs sub-pages

-Context structure change from "ex. " to "e.g.,"
-Grammar in "additional context"
@vercel
Copy link

vercel bot commented Mar 30, 2025

@digichi is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 30, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns wbnns added the base docs review To be reviewed by the Base docs team label Apr 14, 2025
Copy link
Contributor

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wbnns wbnns closed this May 7, 2025
@wbnns wbnns reopened this May 7, 2025
@wbnns wbnns enabled auto-merge (squash) May 7, 2025 20:24
@wbnns wbnns merged commit 763a2ac into base:master May 7, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base docs review To be reviewed by the Base docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants