Skip to content

Change Spend Permissions to Spend Limits #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2025
Merged

Change Spend Permissions to Spend Limits #2310

merged 4 commits into from
May 6, 2025

Conversation

@youssefea
Copy link
Contributor

@youssefea youssefea commented May 6, 2025 •
edited
Loading

What changed? Why?

Changing Spend Permissions to Spend Limits:

  • Added a demo on the demos repo
  • Kept the code and variables naming intact as it's built into the code
  • Updated wording in the docs
  • Added redirects for old links

BaseDocs

  • docs.base.org
  • docs sub-pages

@vercel
Copy link

vercel bot commented May 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 7:06pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 7:06pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented May 6, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions
Copy link

github-actions bot commented May 6, 2025

⚠️ File Size Check Results

⚠️ Large Files (Over 10MB):

  • apps/base-docs/docs/public/images/smart-wallet/ProfilesDemo.gif (22.40MB)

Consider reducing the size of these files if possible.

@youssefea youssefea changed the title add spend limits changes Change Spend Permissions to Spend Limits May 6, 2025
ericbrown99
ericbrown99 approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@ericbrown99 ericbrown99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@youssefea youssefea merged commit 680aed9 into master May 6, 2025
10 checks passed
@youssefea youssefea deleted the change-spend-permissions-and-onchain-address branch May 6, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericbrown99 ericbrown99 ericbrown99 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@youssefea @cb-heimdall @ericbrown99