Skip to content

Conversation

@xtbase
Copy link
Contributor

@xtbase xtbase commented Oct 1, 2025

What changed? Why?

  • optimize some assets by converting to avif
  • async load some components on homepage
  • fix gas dropdown breaking things on homepage

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 1, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Oct 1, 2025

You must have Developer access to commit code to Coinbase on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

aayushijain21
aayushijain21 previously approved these changes Oct 1, 2025
@cb-heimdall cb-heimdall dismissed aayushijain21’s stale review October 1, 2025 19:13

Approved review 3290579297 from aayushijain21 is now dismissed due to new commit. Re-request for approval.

@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
base-web Ready Ready Preview Comment Oct 2, 2025 4:12pm

aayushijain21
aayushijain21 previously approved these changes Oct 1, 2025
@cb-heimdall cb-heimdall dismissed aayushijain21’s stale review October 1, 2025 22:21

Approved review 3291249242 from aayushijain21 is now dismissed due to new commit. Re-request for approval.

dgca
dgca previously approved these changes Oct 2, 2025
@cb-heimdall cb-heimdall dismissed dgca’s stale review October 2, 2025 16:10

Approved review 3291707802 from dgca is now dismissed due to new commit. Re-request for approval.

@xtbase xtbase merged commit 5e5211a into master Oct 2, 2025
11 checks passed
@xtbase xtbase deleted the tea/clean-up-assets-async-load branch October 2, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants