No long transactions!

If you intend to deactivate someone, and the process fails mid process,
so you only delete some sessions, or some accesses, you are actually
fine. The system is never left in an incomplete state. And that's really
the only time we should be using transactions with sqlite3 -- to prevent
actual data integrity issues.

The rest of the time, we should optimize for each transaction to be as
quick as possible. The sqlite3 writer lock is the one bottleneck that we
cant afford to overload.

Author: dhh

app/models/user.rb

@@ -24,11 +24,9 @@ def initials
   end
 
   def deactivate
-    transaction do
-      sessions.delete_all
-      accesses.destroy_all
-      update! active: false, email_address: deactived_email_address
-    end
+    sessions.delete_all
+    accesses.destroy_all
+    update! active: false, email_address: deactived_email_address
   end
 
   private