Merge pull request #414 from basecamp/drop-activity-score

Drop activity scoring

Author: dhh

app/javascript/controllers/card_size_controller.js

@@ -1,6 +1,6 @@
 class Card < ApplicationRecord
   include Assignable, Colored, DraftCommenting, Engageable, Eventable, Golden,
-    Messages, Notifiable, Pinnable, Closeable, Scorable, Searchable, Staged,
+    Messages, Notifiable, Pinnable, Closeable, Searchable, Staged,
     Statuses, Taggable, Watchable
 
   belongs_to :collection, touch: true
@@ -21,12 +21,11 @@ class Card < ApplicationRecord
 
   scope :indexed_by, ->(index) do
     case index
-    when "most_active"    then ordered_by_activity
-    when "newest"         then reverse_chronologically
-    when "oldest"         then chronologically
-    when "latest"         then latest
-    when "stalled"        then ordered_by_staleness
-    when "closed"         then closed
+    when "newest"  then reverse_chronologically
+    when "oldest"  then chronologically
+    when "latest"  then latest
+    when "stalled" then chronologically
+    when "closed"  then closed
     end
   end
 

app/models/card.rb

@@ -1,4 +1,4 @@
-<section id="doing-cards" class="cards cards--doing" style="view-transition-name: cards-container;" data-controller="card-size" data-action="turbo:morph@window->card-size#resize">
+<section id="doing-cards" class="cards cards--doing" style="view-transition-name: cards-container;">
   <% if workflow = filter.single_workflow %>
     <%= render "cards/index/workflow_filter", workflow: workflow, filter: filter %>
   <% else %>

app/models/card/scorable.rb

@@ -0,0 +1,8 @@
+class RemoveActivityFromCards < ActiveRecord::Migration[8.1]
+  def change
+    remove_index :cards, :activity_score_order
+    remove_column :cards, :activity_score_order
+    remove_column :cards, :activity_score_at
+    remove_column :cards, :activity_score
+  end
+end