Push Notifications (were) Not Working

[pavelklymenko]

I was trying to make push notifications work (I saw a pop-up at the bottom right of the screen, but it wasn't delivered as a push notification). Jobs completed "successfully," but no notifications arrived.

What I changed?

Code config/initializers/web_push.rb line 23.

Before:

http = Net::HTTP.new(uri.host, uri.port, ipaddr: endpoint_ip)

After:

http = Net::HTTP.new(uri.host, uri.port)
http.ipaddr = endpoint_ip

Why?

Net::HTTP.new signature is:

Net::HTTP.new(address, port, p_addr = :ENV, p_port = nil, ...)

The third argument is for a proxy address, not ipaddr. Passing {ipaddr: endpoint_ip} as a Hash caused TCPSocket#initialize to fail with:

TypeError: Failed to open TCP connection to {ipaddr: "216.239.36.57"}:80
(no implicit conversion of Hash into String)

The way to pin a connection to a specific IP (for SSRF protection) is to set http.ipaddr = endpoint_ip after creating the HTTP object.

After this the notifications started to arrive. Am I doing something wrong?