Fix CI: .validationMessage assertion
#1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve a [CI failure][] related to a hard-coded English validation message expectation failing due to an internationalized actual validation message value. [CI failure]: https://github.com/basecamp/trix/actions/runs/11317691021/job/31471435810#step:5:75
seanpdoyle
commented
Oct 15, 2024
| const valueMissing = required && !value | ||
| const customError = !!customValidationMessage | ||
| const input = Object.assign(document.createElement("input"), { required }) | ||
| const input = makeElement("input", { required }) |
Collaborator
Author
There was a problem hiding this comment.
@jorgemanrubia I'm not sure how to make sure it passes CI on main, but I do think this is worth merging on its own merits, since it re-uses an existing helper instead of an ad hoc combination of Object.assign and Document.createElement.
Collaborator
Author
|
CI on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a CI failure related to a hard-coded English validation message expectation failing due to an internationalized actual validation message value.