Fix short command code bug

examples/config-ini/configly

@@ -299,18 +299,21 @@ parse_args() {
     ;;
 
   set | s )
+    action=set
     shift
     set_parse_args "$@"
     shift $#
     ;;    
 
   get | g )
+    action=get
     shift
     get_parse_args "$@"
     shift $#
     ;;    
 
   list | l )
+    action=list
     shift
     list_parse_args "$@"
     shift $#

examples/custom-strings/test.sh

@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 
-set -x
-
 rm -f ./src/*.sh
 
+set -x
+
 bashly generate
 
 ./download

examples/minimal/test.sh

@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 
-set -x
-
 rm -f ./src/*.sh
 
+set -x
+
 bashly generate
 
 ./download

examples/subcommands/cli

@@ -186,12 +186,14 @@ parse_args() {
     ;;
 
   download | d )
+    action=download
     shift
     download_parse_args "$@"
     shift $#
     ;;    
 
   upload | u )
+    action=upload
     shift
     upload_parse_args "$@"
     shift $#

examples/subcommands/test.sh

@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 
-set -x
-
 rm -f ./src/*.sh
 
+set -x
+
 bashly generate
 
 ./cli

lib/bashly/views/command/command_filter.erb

@@ -8,6 +8,7 @@ case $action in
 
 <%- commands.each do |command| -%>
 <%= command.aliases.join " | " %> )
+  action=<%= command.name %>
   shift
   <%= command.name %>_parse_args "$@"
   shift $#

spec/approvals/examples/custom-strings

@@ -1,4 +1,3 @@
-+ rm -f ./src/root_command.sh
 + bashly generate
 creating user files in src
 created src/root_command.sh

spec/approvals/examples/minimal

@@ -1,4 +1,3 @@
-+ rm -f ./src/root_command.sh
 + bashly generate
 creating user files in src
 created src/root_command.sh

spec/approvals/examples/short-flag

@@ -0,0 +1,14 @@
++ bashly generate
+creating user files in src
+created src/rush_config_command.sh
+created src/rush_get_command.sh
+created ./rush
+run ./rush --help to test your bash script
++ ./rush c
+# this file is located in 'src/rush_config_command.sh'
+# code for 'rush config' goes here
+# you can edit it freely and regenerate (it will not be overwritten)
+args:
++ ./rush g
+missing required argument: REPO
+usage: rush get REPO [options]

spec/approvals/examples/subcommands

@@ -1,4 +1,3 @@
-+ rm -f ./src/cli_download_command.sh ./src/cli_upload_command.sh
 + bashly generate
 creating user files in src
 created src/cli_download_command.sh

spec/bashly/integration/script_spec.rb → spec/bashly/integration/examples_spec.rb

@@ -6,11 +6,19 @@
 # folder
 
 describe 'generated bash scripts' do
+  # Test public examples from the examples folder...
   examples = Dir["examples/*"].select { |f| File.directory? f }
 
+  # ...as well as internal examples, not suitable for public view
+  fixtures = Dir["spec/fixtures/workspaces/*"].select { |f| File.directory? f }
+
+  test_cases = fixtures + examples
+
   leeway = ENV['CI'] ? 40 : 0
 
-  examples.each do |example|
+  test_cases.each do |example|
+    approval_name = example.gsub "spec/fixtures/workspaces", "examples"
+
     describe example do
       it "works" do
         output = "not executed"
@@ -22,7 +30,7 @@
         # This was observed in at least these two cases:
         # - The "+ ..." shell messages driven by `set -x` have no space
         # - The order of our `inspect_args` sometimes differs
-        expect(output).to match_fixture(example).diff(leeway)
+        expect(output).to match_fixture(approval_name).diff(leeway)
       end
     end
   end

spec/fixtures/workspaces/short-flag/.gitignore

@@ -0,0 +1,2 @@
+rush
+src/*.sh

spec/fixtures/workspaces/short-flag/README.md

@@ -0,0 +1,2 @@
+This fixture tests that short flags work properly
+Reference issue: https://github.com/DannyBen/bashly/issues/16

spec/fixtures/workspaces/short-flag/src/bashly.yml

@@ -0,0 +1,17 @@
+name: rush
+help: Personal package manager
+version: 0.1.0
+
+commands:
+- name: config
+  short: c
+  help: Show the configuration file
+
+- name: get
+  short: g
+  help: Install a package
+
+  args:
+  - name: repo
+    required: true
+    help: Repository name

spec/fixtures/workspaces/short-flag/test.sh

@@ -0,0 +1,14 @@
+#!/usr/bin/env bash
+
+# This fixture tests that short flags work properly
+# Reference issue: https://github.com/DannyBen/bashly/issues/16
+
+rm -f ./src/*.sh
+rm -f ./rush
+
+set -x
+
+bashly generate
+
+./rush c
+./rush g