Remove support for arbitrary script test to fix zsh incompatibilities #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_init_completionin the generated script, introduced in Improve template #12 and Improve template (fixed) #13 broke ZSH compatibility - so the function is removed with this PR.source /usr/share/bash-completion/bash_completionline in the script tester template is also not zsh compatible - so it was removed as well.completely testercommand can no longer be used for testing arbitrary scripts. It is now confined to testing completely scripts only.COMPLETELY_SCRIPT_PATHenvironment variable was changed toCOMPLETELY_OUTPUT_PATH.There might be a way to bring this functionality back, but since 0.4.0 is currently broken for zsh users, this fix is necessary.
Closes #20