Skip to content

Conversation

bashtage
Copy link
Owner

@bashtage bashtage commented Nov 2, 2019

Update to reflect changes in NumPy

@pep8speaks
Copy link

pep8speaks commented Nov 2, 2019

Hello @bashtage! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-02 10:48:43 UTC

@bashtage bashtage force-pushed the update-hypergeometric branch from fa61e3d to 5d08f15 Compare November 2, 2019 10:24
Update to reflect changes in NumPy
@bashtage bashtage force-pushed the update-hypergeometric branch from 5d08f15 to 3b079b0 Compare November 2, 2019 10:48
@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #189 into master will decrease coverage by 0.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   94.61%   94.59%   -0.02%     
==========================================
  Files          38       38              
  Lines       10343    10348       +5     
  Branches      167      165       -2     
==========================================
+ Hits         9786     9789       +3     
- Misses        533      536       +3     
+ Partials       24       23       -1
Impacted Files Coverage Δ
randomgen/tests/test_randomstate_regression.py 99.05% <ø> (ø) ⬆️
randomgen/tests/test_generator_117.py 63.63% <0%> (-0.7%) ⬇️
randomgen/tests/test_against_numpy.py 99.05% <100%> (-0.24%) ⬇️
randomgen/tests/test_randomstate.py 99.09% <100%> (ø) ⬆️
randomgen/tests/test_direct.py 98.7% <100%> (ø) ⬆️
...domgen/tests/test_generator_mt19937_regressions.py 100% <100%> (+0.96%) ⬆️
randomgen/tests/test_generator_mt19937.py 99.33% <100%> (ø) ⬆️
randomgen/generator.pyx 92.78% <100%> (+0.05%) ⬆️
randomgen/common.pyx 81.06% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba54798...3b079b0. Read the comment docs.

@bashtage bashtage merged commit 822abe8 into master Nov 2, 2019
@bashtage bashtage deleted the update-hypergeometric branch November 2, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants