Skip to content

Conversation

@AKST
Copy link
Contributor

@AKST AKST commented Jul 16, 2017

Description

  • Modified _untilEnd & _untilReadable methods
    • return type is a object with a clean up callback & the promise
  • Modified the logic utilising _untilEnd & _untilReadable to clean up the promises

Meta

While the original Issue I opened is yet to receive a response I decided to go ahead and try my solution. It resolves the issue I was having & I am no longer receiving the warnings of too many event listeners.

But since I've submitted before any feedback, I'm well aware this solution could possibly be not what you're looking for. That said I tried to comment on as much as possible, and try to emulate your code style, and if you're


fixes #5

@AKST
Copy link
Contributor Author

AKST commented Jul 16, 2017

I removed the yarn lock file i generated as I figured it's possible it's undesired for this library

@basicdays
Copy link
Owner

Seems simple enough. I'll check it out tonight and hopefully accept the PR. Thanks for the contribution.

@basicdays
Copy link
Owner

So, 50 years later, finally got back to this. Just tried it out and things seem fine. Merging now. Have another issue that I'm also going to publish with this. Sorry about the long wait......... >_>

@basicdays basicdays merged commit 85933cc into basicdays:master May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

End handlers not being removed after next resolve

2 participants