-
Notifications
You must be signed in to change notification settings - Fork 120
use cffi's out-of-line mode to reduce import time #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you still run SoundFile without having a compiler installed? |
|
yup! Check out the details here |
|
Looks good to me. Did you check that this works on Windows, Linux, macOS? |
|
I tested it on Linux, and I can test it on Windows. I don't have access to
a mac. Doesn't travis cover this though?
…On Tue, Oct 17, 2017 at 2:19 AM, Bastian Bechtold ***@***.***> wrote:
Looks good to me. Did you check that this works on Windows, Linux, macOS?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/bastibe/PySoundFile/pull/211#issuecomment-337140819>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAaVHFYMjQamheZ6fN1nGW6VWB5I9_FDks5stFUOgaJpZM4P5o17>
.
|
|
I think travis only runs this on Linux. I can run it on a Mac, but I don't have a Windows machine handy. |
|
I checked the Mac version and it works fine. Import times are indeed cut in half, on my machine: > git checkout master
> time python -c "import soundfile"
0.13 real 0.12 user 0.01 sys
> git checkout tgarc-out-of-line-mode
0.06 real 0.15 user 0.01 sys |
|
I'll merge once you confirm that the Windows side works, too. Thank you very much for your efforts! |
|
Tested on a windows 7 box and again it cut down import time by half |
|
Thank you very much! |
Switching to out-of-line ABI mode (bastibe#211) broke this. See also spatialaudio/python-sounddevice#102.
Switching to out-of-line ABI mode (bastibe#211) broke this. See also spatialaudio/python-sounddevice#105.
Same request as for sounddevice:
spatialaudio/python-sounddevice#102
This change adds one more file to the repository but doesn't really change anything else other than improving import time