Skip to content

Conversation

@tgarc
Copy link
Contributor

@tgarc tgarc commented Oct 15, 2017

Same request as for sounddevice:
spatialaudio/python-sounddevice#102

This change adds one more file to the repository but doesn't really change anything else other than improving import time

@bastibe
Copy link
Owner

bastibe commented Oct 16, 2017

Can you still run SoundFile without having a compiler installed?

@tgarc
Copy link
Contributor Author

tgarc commented Oct 16, 2017

yup! Check out the details here

@bastibe
Copy link
Owner

bastibe commented Oct 17, 2017

Looks good to me. Did you check that this works on Windows, Linux, macOS?

@tgarc
Copy link
Contributor Author

tgarc commented Oct 17, 2017 via email

@bastibe
Copy link
Owner

bastibe commented Oct 18, 2017

I think travis only runs this on Linux. I can run it on a Mac, but I don't have a Windows machine handy.

@bastibe
Copy link
Owner

bastibe commented Oct 18, 2017

I checked the Mac version and it works fine. Import times are indeed cut in half, on my machine:

> git checkout master
> time python -c "import soundfile"
        0.13 real         0.12 user         0.01 sys
> git checkout tgarc-out-of-line-mode
        0.06 real         0.15 user         0.01 sys

@bastibe
Copy link
Owner

bastibe commented Oct 18, 2017

I'll merge once you confirm that the Windows side works, too. Thank you very much for your efforts!

@tgarc
Copy link
Contributor Author

tgarc commented Oct 18, 2017

Tested on a windows 7 box and again it cut down import time by half

@bastibe bastibe merged commit 0eb546e into bastibe:master Oct 19, 2017
@bastibe
Copy link
Owner

bastibe commented Oct 19, 2017

Thank you very much!

mgeier added a commit to mgeier/python-soundfile that referenced this pull request Oct 19, 2017
Switching to out-of-line ABI mode (bastibe#211) broke this.
See also spatialaudio/python-sounddevice#102.
mgeier added a commit to mgeier/python-soundfile that referenced this pull request Oct 19, 2017
Switching to out-of-line ABI mode (bastibe#211) broke this.
See also spatialaudio/python-sounddevice#105.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants