creating blocksize length output array in blocks reading if fill_value is set regardless of frames in file #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is set regardless of frames in file
Owner
|
Thank you very much for promptly fixing this regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR fixing blocks reading for files shorter than the specified blocksize, a regression was introduced resulting that even if the
fill_valuewas specified, at most as many frames were read as the file had instead of the blocksize with the padding used. In this PR we add a fix so that if the fill_value is specified (and the output array is not), we will create an output array of blocksize regardless if the file doesn't have as many frames. Also added more unit tests to cover all these cases.The regression mentioned above is part of version
0.13.0of soundfile. Suggestion is to create a new version0.13.1with this fix included.