Skip to content

Conversation

@keatliang2005
Copy link
Contributor

This PR is attempt to fix #516, as on post #516 (comment) pointed out, it already provide the arg to not execute save.

so we can leverage that, if user id is not present, we set the method getWallet argument $save as false.

this will ensure, when authenticated user id will auto save,
when execute without any authentication for this instance, laravel-ide-helper would not execute save

➜  laravel-wallet git:(master) ✗ phpunit --stop-on-failure
PHPUnit 9.5.20 #StandWithUkraine

Runtime:       PHP 8.0.8
Configuration: /Users/keatliang/Downloads/laravel-wallet/phpunit.xml
Warning:       No code coverage driver available

...............................................................  63 / 193 ( 32%)
............................................................... 126 / 193 ( 65%)
............................................................... 189 / 193 ( 97%)
....                                                            193 / 193 (100%)

Time: 00:06.076, Memory: 56.00 MB

OK (193 tests, 1653 assertions)

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #517 (51959ec) into master (3a9c2e8) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #517   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       428       428           
===========================================
  Files             68        68           
  Lines           1313      1313           
===========================================
  Hits            1313      1313           
Impacted Files Coverage Δ
src/Traits/HasWallet.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9c2e8...51959ec. Read the comment docs.

@keatliang2005
Copy link
Contributor Author

➜ laravel-wallet git:(master) ✗ phpunit --stop-on-failure
PHPUnit 9.5.20 #StandWithUkraine

Runtime: PHP 8.0.8
Configuration: /Users/keatliang/Downloads/laravel-wallet/phpunit.xml
Warning: No code coverage driver available

............................................................... 63 / 193 ( 32%)
............................................................... 126 / 193 ( 65%)
............................................................... 189 / 193 ( 97%)
.... 193 / 193 (100%)

Time: 00:06.356, Memory: 56.00 MB

OK (193 tests, 1657 assertions)

@rez1dent3 rez1dent3 merged commit 8dadd2f into bavix:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

barryvdh/laravel-ide-helper model generate bug

2 participants