ECDF-Difference Plot: Rank ECDF Line Does Not Cover Full Range [0,1]

[philippreiser]

Hi!
I am using bf.diagnostics.plots.calibration_ecdf to create ECDF-Difference plots. However, I noticed that the Rank ECDF line sometimes starts after rank=0.0 and ends before rank=1.0, which I think is not expected.

Here's a minimal example:

import os

if "KERAS_BACKEND" not in os.environ:
    os.environ["KERAS_BACKEND"] = "torch"

import bayesflow as bf
import keras
import numpy as np
import matplotlib.pyplot as plt

rng = np.random.default_rng(10)

targets = rng.normal(loc = 1, scale = 0.2, size = (100, 1))
estimates = rng.normal(loc = 1, scale= 0.3, size = (100, 1))

bf.diagnostics.plots.calibration_ecdf(
    estimates=estimates, 
    targets=targets,
    difference=True,
    rank_type="fractional"
)
plt.show()

[paul-buerkner]

Thanks I will check and fix this asap.

[paul-buerkner]

Should now be fixed on the improve-diag branch. Can you double check that this indeed works?

[philippreiser]

Yes, works now. Thanks!

[stefanradev93]

Does padding produce the desired behavior? Doesn't it somewhat distort the picture?