-
Notifications
You must be signed in to change notification settings - Fork 78
add tests for summary networks [WIP] #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests for summary networks [WIP] #202
Conversation
* add fixtures for some summary network types * add a test for compute_metrics method of summary networks
|
Thank you for the PR. Please make sure that the linter passes before merging. |
|
In an attempt to merge this PR, I noticed that there are some unknown arguments used in @LarsKue I think you will need to check and fix this before you can merge it as I don't understand the context in which these changes were made. |
|
@paul-buerkner please never merge PRs that do not at the very least pass all tests, unless you have very good reason to. I will look into this as soon as I have a time slot available. |
|
I did not intend to merge this PR without consultation (even if all tests would have passed, which they are not because of the issue I brought up). I just wanted to move it forward. My earlier message was unclear in this regard. Sorry for that. |
|
In an attempt to move this PR forward, I realized that it's probably safer to make a new PR extending tests for summary networks, rather to rely on this one. It currently has too many loose ends that I am not quite able to fit together. |
|
I think I figured out what were the issues and was able to get all the tests running again. Changes to the code base outside of the tests are minimal. They only concern the consistent storing of I will merge as soon as all checks are passing. |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
I will be adding more commits to this PR as per instructions from @LarsKue.
Updates to test fixtures:
tests/conftest.py: Modified thesummary_networkfixture to accept thesummary_dimparameter.tests/test_networks/conftest.py: Added new fixtures forsummary_dim,key_dim, and various network instances (lst_net,set_transformer,set_transformer_key_dim_variation,deep_set).New test cases:
tests/test_networks/test_summary_networks.py: Introduced new test casestest_compute_metricsandtest_set_transformer_with_key_dimto verify the functionality of the new attributes and ensure the correctness of the network outputs.