Move continuous-time consistency model to experimental module. #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to bayesflow-org#256 As we have not extensively tested their behavior and I have observed subpar performance in some settings, we move this model class to experimental for further testing, to see whether it is ready for broader use, or whether it turns out to be too unstable to be practical.
Collaborator
Author
|
@stefanradev93 How much structure do we want in the experimental module? For now I just used a single file inside the module, but if we want a more nested structure, I will move the files around accordingly. |
Contributor
|
I think the structure is fine for now. As you suggest, I would include an |
Collaborator
Author
|
Thanks for taking a look! have made the corresponding change... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #256
As we have not extensively tested their behavior and I have observed subpar performance in some settings, we move this model class to experimental for further testing, to see whether it is ready for broader use, or whether it turns out to be too unstable to be practical.