fix issue #328 #333
Merged
fix issue #328 #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarsKue
approved these changes
Feb 21, 2025
Contributor
LarsKue
left a comment
LarsKue
left a comment
There was a problem hiding this comment.
Thank you for the fix! I would merge this as-is, but a much simpler way to remove a single key would be:
conditions.pop("inference_variables", None)in case you want to implement this.
Contributor
Author
|
Ah yeah, will change this. Thank you! |
Contributor
Author
|
Changed. |
Contributor
|
@paul-buerkner Let's also add a comment to the Model Comparison line, so it doesn't confuse readers. |
Contributor
Author
|
done. |
Member
|
Yes, this PR fixes the issue :) |
Contributor
Author
|
Lovely, @LarsKue merge away if you are happy too :-) |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #328 by removing
inference_variablesfrom conditions in the continuous approximator before passing conditions to the networks. Taggine @Kucharssim to double check that this fixes the issue and @LarsKue for reviewing this PR.