Skip to content

Conversation

@Kucharssim
Copy link
Member

PR #321 broke the ece because the function made an incorrect assumption that if the inputs are not type of np.ndarray, they must be tf.Tensor with a .numpy() method.

The fix can be tested against the model comparison example notebook.

@paul-buerkner
Copy link
Contributor

Looks good. Thank you! Waiting for checks to pass and will then merge.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bayesflow/utils/comp_utils.py 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
bayesflow/utils/comp_utils.py 17.39% <33.33%> (+4.89%) ⬆️

@paul-buerkner paul-buerkner merged commit 93ca6a9 into bayesflow-org:dev Feb 21, 2025
13 checks passed
@Kucharssim Kucharssim deleted the fix-mc_calibration branch February 24, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants