Skip to content

Conversation

@promptless
Copy link
Contributor

@promptless promptless bot commented Oct 18, 2025

After reviewing the complete list of 19 upstream commits in PR #80's compare view (not just the 10 shown in the PR description), I identified one documentation fix that should be applied to our fork:

Java toolchain formatting fix (commit e23f78f): Improves the bullet list formatting in the "Configuring the Java toolchains" section of docs/bazel-and-java.mdx. Changes include using * instead of - for bullets, adding proper spacing, and adding "the" before flag names for better readability.

Note: I also discovered that external/extension.mdx is completely missing from our fork (listed in copy-upstream-docs.sh but not present). This is a significant documentation gap for module extensions, but it's a pre-existing issue not introduced by PR #80. This warrants a separate investigation/suggestion.

Open this suggestion in the Promptless dashboard


Help us improve Promptless — If this suggestion missed the mark, please share quick feedback.

If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)

@promptless
Copy link
Contributor Author

promptless bot commented Oct 18, 2025

I've added the requested changes in commit 5764bfd

@alan707
Copy link
Collaborator

alan707 commented Oct 19, 2025

LGTM

@promptless
Copy link
Contributor Author

promptless bot commented Oct 19, 2025

Just a reminder: If you'd like me to act on any feedback you have via Github comments, just type @Promptless in your suggestion and I'll get right on it! (I won't show up in the user dropdown, but I'll process any request that has @Promptless in the comment body.)

@alan707 alan707 merged commit 4f5a7be into main Oct 19, 2025
3 checks passed
@alan707 alan707 deleted the promptless/pr80-missed-upstream-commits branch October 19, 2025 18:36
@alan707
Copy link
Collaborator

alan707 commented Oct 19, 2025

@Promptless please create a PR to address this:

Note: I also discovered that external/extension.mdx is completely missing from our fork (listed in copy-upstream-docs.sh but not present). This is a significant documentation gap for module extensions, but it's a pre-existing issue not introduced by PR https://github.com/alan707/bazel-docs/pull/80. This warrants a separate investigation/suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants