-
-
Notifications
You must be signed in to change notification settings - Fork 636
feat(toolchains): Add 3.14.0 #3330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Ahajha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the newly released Python 3.14.0 into the project's toolchain. It updates the version definitions, download artifacts, and checksums from a release candidate to the stable release, ensuring that the latest Python version is fully supported and available for use within the build system and tests. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Python 3.14.0 by updating the toolchain versions, SHA256 hashes, and relevant mappings. The changes look good overall. I've added a couple of suggestions to improve code maintainability by sorting dictionary keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
"3.14.0rc1": { | ||
"url": "20250808/cpython-{python_version}+20250808-{platform}-{build}.{ext}", | ||
"3.14.0": { | ||
"url": "20251007/cpython-{python_version}+20251007-{platform}-{build}.{ext}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have loved to see the other toolchains from the same release to be also added, because that normally brings a number of fixes together. Nevertheless, thank you for contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that would make sense, just bumped this one since it addressed my immediate needs. I might add those, do you usually add them or replace the existing ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the existing versions if they overlap and add a small note in the CHANGELOG for the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, will try to get to that tomorrow.
Per request in #3330 (comment) --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
Per the title: 3.14.0 was released today.