Skip to content

Conversation

@aignas
Copy link
Collaborator

@aignas aignas commented Nov 20, 2025

Add changelog for #3387

@aignas aignas requested a review from rickeylev as a code owner November 20, 2025 07:39
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the project's changelog to reflect recent changes in Python toolchain support. Specifically, it adds formal documentation for the removal of Python 3.8 toolchain support, providing crucial information for users on how to manage this change. Additionally, an existing entry for Python 3.9 toolchain removal has been enhanced with a relevant issue reference, ensuring the changelog remains accurate and informative.

Highlights

  • Python 3.8 Toolchain Removal Documentation: Added a new entry to the changelog documenting the removal of Python 3.8 toolchain support out of the box. This entry clarifies that users must explicitly pass TOOL_VERSIONS or use bzlmod APIs to re-enable Python 3.8, and that pip.parse calls targeting 3.8 will now be ignored.
  • Python 3.9 Toolchain Removal Update: Updated the existing changelog entry regarding the removal of Python 3.9 toolchain versions (except 3.9.25) to include a reference to issue Remove Python 3.8 and 3.9 #2704.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a changelog entry for the removal of Python 3.8 toolchain support. My review identifies a potential discrepancy in the referenced issue number within the new changelog entry, which should be corrected for accuracy.

@aignas aignas enabled auto-merge November 20, 2025 07:49
@aignas aignas added this pull request to the merge queue Nov 22, 2025
Merged via the queue into bazel-contrib:main with commit b57eba9 Nov 22, 2025
4 checks passed
@aignas aignas deleted the aignas.doc.python3.8 branch November 22, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants