Skip to content

Only emit sysroot warning when bazel is new enough #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

Only emit sysroot warning when bazel is new enough #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion toolchain/internal/system_module_map.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def _system_module_map(ctx):
if len(sysroot_files) == 1:
template_dict.add("%sysroot%", umbrella_submodule_closure(sysroot_files[0]))
else:
if sysroot_files:
if sysroot_files and bazel_features.rules.merkle_cache_v2:
# buildifier: disable=print
print("WARNING: Sysroot {} resolved to {} files. Consider using the `sysroot` repository rule in @toolchains_llvm//toolchain:sysroot.bzl which provides a single-file (directory) sysroot for more efficient builds.".format(
ctx.attr.sysroot_files.label,
Expand Down