Fixed dangling symlinks in builds#656
Fixed dangling symlinks in builds#656UebelAndre merged 2 commits intobazel-contrib:mainfrom UebelAndre:symlink
Conversation
jsharpe
left a comment
There was a problem hiding this comment.
+1 as this fixes the dangling symlinks for the specified outputs but we still have #449 to think about how to handle properly - its not ideal that we end up with copies of shared libraries which should be symlinks. ldconfig complains about the fact that the .so library isn't a symlink.
I've not checked but do we also have broken symlinks in the gen_dir output too?
Yeah, this would have been an existing issue from before #575 This change restores previous behavior but is still incorrect but incorrect for functionality that didn't work or was undefined previously. |
In some cases, the assumed output for a build,
lib*.so, is actually a symlink which points tolib*.#.#.#.so. This results in issues likeTo fix this, any explicitly requested output should be resolved to it's full file.