Remove kt_jvm_plugin_aspect now that all versions of Bazel support JavaPluginInfo #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restingbull
approved these changes
Apr 12, 2023
| return depset(transitive = [t[KtJvmPluginInfo].transitive_runtime_jars for t in targets if KtJvmPluginInfo in t]) | ||
| return depset( | ||
| transitive = [ | ||
| (t[_JavaPluginInfo] if _JavaPluginInfo in t else t[JavaInfo]).plugins.processor_jars |
Collaborator
There was a problem hiding this comment.
let me guess -- None in t is False?
Collaborator
Author
There was a problem hiding this comment.
_JavaPluginInfo should never be null as it was released in Bazel 5 and we technically do not support versions before 5.
Bencodes
deleted the
remove-kt_jvm_plugin_aspect-now-that-all-versions-of-bazel-support-javaplugininfo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaPluginInfowas added in Bazel 5.x which means that it exists by default for all versions of Bazel that we officially support inrules_kotlinwhich means that we should no longer be applying thekt_jvm_plugin_aspectaspect. It should be safe to remove now.This also defaults the rest plugins.bzl over to using
JavaPluginInfodirectly.