presubmit.yml: Set skip_use_bazel_version_for_test: true#1538
Merged
alexeagle merged 1 commit intobazel-contrib:masterfrom Jan 14, 2020
Merged
Conversation
meteorcloudy
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
Collaborator
Author
|
ping @alexeagle @gregmagolan We need rules_nodejs to be green so that we can make sure the next release won't break anything for rules_nodejs. |
Collaborator
|
Okay, synced on this with @gregmagolan and we want to better understand the conflict between this new Bazel In the meantime we'll merge this to unblock testing rules_nodejs for next release |
|
Is there somewhere I can read about this new feature? |
meteorcloudy
added a commit
to meteorcloudy/rules_python
that referenced
this pull request
Aug 6, 2020
This will fix recent test breakage in Bazel downstream: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1588#91ed10dd-2b13-4cee-99cc-88a2e8e58a31 Similar issue and fix: bazelbuild/bazel#10554 bazel-contrib/rules_nodejs#1538
13 tasks
thundergolfer
pushed a commit
to bazel-contrib/rules_python
that referenced
this pull request
Aug 14, 2020
This will fix recent test breakage in Bazel downstream: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1588#91ed10dd-2b13-4cee-99cc-88a2e8e58a31 Similar issue and fix: bazelbuild/bazel#10554 bazel-contrib/rules_nodejs#1538
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules_nodejs is currently failing in Bazel's Downstream Pipeline due to bazelbuild/bazel#10554
We need this change to tell Bazel CI to not pass
--test_env=USE_BAZEL_VERSIONfor Angular's integration tests.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information