Add workaround for arm vs armv7 android issue #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building for the armv7 android target, we would ideally specify a cpu:armv7 constraint, but because of the linked bazel issue this is currently hardcoded as arm in bazel's NDK setup. As far as I can tell the platform we request for use with rules rust has to match the constraints in bazel, otherwise it won't discover the NDK CC toolchain for linking.
UebelAndre
approved these changes
Apr 14, 2022
Collaborator
There was a problem hiding this comment.
This seems acceptable to me. But @hlopko could you take a look too? Feel free to merge if you think this is acceptable too.
Member
Author
|
Note I also submitted bazelbuild/bazel#15248 but it's unclear to me if that will be a reasonable change, it might break some stuff that I don't know about |
Member
Author
|
Thanks all! |
keith
added a commit
to keith/rules_rust
that referenced
this pull request
Apr 25, 2022
This reverts commit f6f27a8.
UebelAndre
added a commit
that referenced
this pull request
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building for the armv7 android target, we would ideally specify a
cpu:armv7 constraint, but because of the linked bazel issue this is
currently hardcoded as arm in bazel's NDK setup. As far as I can tell
the platform we request for use with rules rust has to match the
constraints in bazel, otherwise it won't discover the NDK CC toolchain
for linking.