Add bazel-* directories in cargo_manifest_dir/external_crate to gitignore #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
force-pushed
the
ignore
branch
3 times, most recently
from
5e26162 to
e03d67d
Compare
Collaborator
|
@dtolnay Hey, if you rebase this I'd be happy to merge it 😄 |
…nore
Previously running `bazel build ...` in examples/cargo_manfest_dir/external_crate
would leave the following untracked files:
Untracked files:
(use "git add <file>..." to include in what will be committed)
examples/cargo_manifest_dir/external_crate/bazel-bin
examples/cargo_manifest_dir/external_crate/bazel-external_crate
examples/cargo_manifest_dir/external_crate/bazel-out
examples/cargo_manifest_dir/external_crate/bazel-testlogs
I noticed that of the 5 workspaces found by `find . -name WORKSPACE.bazel`
three of them were ignoring "bazel-*" via the top-level .gitignore while
one had its own .gitignore containing only "bazel-*". I consolidated
that one into the top-level .gitignore and added the 5th.
Contributor
Author
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously running
bazel build ...in examples/cargo_manfest_dir/external_crate would leave the following untracked files:I noticed that of the 5 workspaces found by
find . -name WORKSPACE.bazelthree of them were ignoringbazel-*via the top-level .gitignore while one had its own .gitignore containing onlybazel-*. I consolidated that one into the top-level .gitignore and added the missing 5th.