feat: support extra deps in rust_doc_test #1286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `rust_doc_test` (unlike `rust_test`) doesn't support adding extra test-only dependencies, which makes it unnecessarily hard to migrate doc tests from Cargo to rules_rust. This change extends the `rust_doc_test` rust to support extra test-only dependencies.
I'm getting unnecessarily proficient in this.
UebelAndre
requested changes
Apr 22, 2022
UebelAndre
approved these changes
Apr 22, 2022
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Looks good to me! Seems that buildifier needs to be run though.
Contributor
Author
Thank you, @UebelAndre! I fixed the formatting. Could you please merge this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
rust_doc_test(unlikerust_test) doesn't support addingextra test-only dependencies, which makes it unnecessarily hard to
migrate doc tests from Cargo to rules_rust.
This change extends the
rust_doc_testrust to support extratest-only dependencies.