Release 0.27.0 #2130
Merged
Release 0.27.0 #2130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I would like this release to include the following changes |
Contributor
|
I'll add that unit test ASAP today. |
Collaborator
Author
Thanks! No rush, just communicating what I'm hoping to have in before merging this PR 😄 |
Contributor
|
It would be great if this release could pick up this PR as well. It's approved and just hitting the same infra failure this release is hitting. |
Contributor
|
For the "_coverage_report.dat: No such file or directory" failure: I found if you amend and force-push the PR to retrigger the job, eventually it will pass after a few tries. |
Collaborator
|
I'd love to sneak #2139 in if I can |
Contributor
|
Any chance we could get #2119 in too? Would love to drop my local patches |
…uild#2139) My use-case here is needing to point at different paths for libclang.so when using bindgen on different platforms. This allows specifying build script env vars in annotations like: ```starlark build_script_env = { "BORING_BSSL_PATH": "$(execpath @//third_party/boringssl:gen_dir)", "LIBCLANG_PATH": { "x86_64-unknown-linux-gnu": "$(execpath @libclang_linux_x86_64//file:libclang.so)", }, }, ``` which will unconditionally set `$BORING_BSSL_PATH`, but will only set `$LIBCLANG_PATH` on x86-64 Linux. We could in theory support this kind of construct for all annotation fields, but I've only added it where I happened to need it for now.
Fixes bazelbuild#2120 Co-authored-by: UebelAndre <github@uebelandre.com>
illicitonion
approved these changes
Aug 31, 2023
ttiurani
pushed a commit
to ttiurani/rules_rust
that referenced
this pull request
Sep 15, 2023
Co-authored-by: Daniel Wagner-Hall <dwagnerhall@apple.com> Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.