Skip to content

process_wrapper: write all output from rustc if json parsing fails. #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2023
Merged

process_wrapper: write all output from rustc if json parsing fails. #2234

merged 1 commit into from
Nov 3, 2023

Conversation

@gigaroby
Copy link
Contributor

@gigaroby gigaroby commented Nov 2, 2023

Previously we were only reporting the first line of any error rustc may emit when it panic'd or otherwise unexpectedly stopped outputting json.

@gigaroby
process_wrapper: dump all output from rustc if json parsing fails.
e093161 
Previously we were only reporting the first line of any error rustc may
emit when it panic'd or otherwise unexpectedly stopped outputting json.
scentini
scentini approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@scentini scentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scentini scentini merged commit 9341d1f into bazelbuild:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scentini scentini scentini approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gigaroby @scentini