Take into account DependencyKind when collecting package target dependencies #2235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dmitrii-ubskii
force-pushed
the
optional-build-dep
branch
from
06a4ce7 to
2a19628
Compare
UebelAndre
approved these changes
Nov 2, 2023
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Thanks! All that's needed is a rebase and this can then be merged 😄
dmitrii-ubskii
force-pushed
the
optional-build-dep
branch
from
2a19628 to
2641f3a
Compare
Contributor
Author
|
Rebased! |
Collaborator
|
Alas! I’m too late and another change was merged lol. One more rebase? |
dmitrii-ubskii
force-pushed
the
optional-build-dep
branch
from
2641f3a to
a190343
Compare
Contributor
Author
|
Done. |
illicitonion
pushed a commit
that referenced
this pull request
Dec 1, 2023
Follow-up to #2235 that corrects the `DependencyKind` used. This bug caused optional dependencies to be incorrectly _included_ even no feature activated that dependency. This can lead to crates being compiled with missing features, resulting in compile errors. For example, `sqlx==0.7.3` compiled successfully with `0.30.0`, but fails with `0.31.0`: ```toml sqlx = { version = "0.7.3", default-features = false, features = ["sqlite"] } ``` because `default-features = false` should remove the [optional dependency](https://github.com/launchbadge/sqlx/blob/c55aba0dc14f33b8a26cab6af565fcc4c8af8962/Cargo.toml#L54-L56) `sqlx-macros`. Instead, however, it gets incorrectly included but with its crate dependencies' features missing, resulting in compile errors. Related issue: - #2262
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When filtering out disabled dependencies for the Bazel targets,
collect_deps_selectable()now takes into account the kind of dependency in question. Previously, if a disabled optional normal dependency was mandatory for a build script, it was erroneously filtered out.This change resolves #2059