Bump cargo_toml to 0.17.1 #2278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
requested changes
Nov 22, 2023
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Can you also run bazel run //crate_universe/3rdparty:crates_vendor?
This includes https://gitlab.com/lib.rs/cargo_toml/-/merge_requests/20 which fixes a non-determinism issue in the lockfile.
illicitonion
force-pushed
the
bump-cargo_toml
branch
from
5b58a1f to
964aa6e
Compare
Collaborator
|
You may also wanna bump the version of the |
UebelAndre
approved these changes
Nov 22, 2023
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
I'd bump the version of cargo_bazel but not required here. Good to merge!
UebelAndre
approved these changes
Nov 22, 2023
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
If you bump the version I think you'll need to repin all the examples. The version of cargo-bazel contributes to the hash in the lock files.
UebelAndre
approved these changes
Nov 23, 2023
UebelAndre
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes https://gitlab.com/lib.rs/cargo_toml/-/merge_requests/20 which fixes a non-determinism issue in the lockfile.