Added support for multiple javascript rule sets to wasm_bindgen package #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
UebelAndre
force-pushed
the
wasm
branch
6 times, most recently
from
0bf7842 to
96b033b
Compare
dzbarsky
reviewed
Nov 25, 2023
Contributor
dzbarsky
left a comment
dzbarsky
left a comment
There was a problem hiding this comment.
this looks great, thanks for finding another path forward. We'll need to do a bit of work here to support bzlmod as well but that can be in other PRs
illicitonion
approved these changes
Nov 27, 2023
|
|
||
| ### Interfacing with Javascript rules | ||
|
|
||
| While it's recommended for users to mantain their own , in the |
Collaborator
There was a problem hiding this comment.
Missing word after "own"?
UebelAndre
added a commit
that referenced
this pull request
Jan 5, 2024
#2284 removed the .wasm output file from the `DefaultInfo` provider, which makes it unavailable to other downstream rules. This PR restores the behavior pre-0.32.0. --------- Co-authored-by: UebelAndre <github@uebelandre.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the core
rust_wasm_bindgenrule into a standalone rule that users can user to write custom interfaces into any rules/targets they desire while also supporting interfaces for existing Javascript rule sets. Users loading the root@rules_rust//wasm_bindgensymbols will be using the core Rust rules, where users loading symbols from the new sub directoriesrules_nodejsandrules_jswill have variants that offer better integrations.