Use js_info macro to populate JsInfo provider (js_rust_wasm_bindgen) #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Showcases a bug currently in with the way the JsInfo provider is populated. There are fields missing and attempts to read from them will result in error
The js_info macro will populate unspecified fields with empty lists
UebelAndre
requested changes
Dec 3, 2023
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Thanks!
Would you also be willing to leave an example showing a direct consumer to js_test? I've found this more closely resembles js_binary but will report that execution still works.
Contributor
Author
|
I'm not sure I understand. Sorry if a naive question, but can you specify a rule that consume the result of a test target? Or do you mean a direct consumer to the first |
Collaborator
|
I’d like to keep the original test target but add your more library + test combo |
One test that directly consumes the WASM data and another that indirectly consumes (through intermediate js_library)
Contributor
Author
|
Ok, I split it out into two tests as you suggested. One that consumes the WASM data directly and one the consumes it indirectly (via an intermediate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
js_infomacro in aspect_rules_js to create theJsInfoprovider and provide defaults for any field that is not explicitly set.Resolves #2302