Introduced TargetTriple newtype.
#2315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Dec 12, 2023
Collaborator
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Very nice, thanks!
rickvanprim
force-pushed
the
target_triple
branch
from
b040164 to
44c3e53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Slack with @illicitonion (hopefully). With the
Selectrefactor, we presumably wantselectsto be keyed byTargetTripleinstead ofString. Please let me know if you have a better interface forTargetTripleand/or any bikesheds 🙂