Skip to content

Fix aliased crate handling in aliases attribute #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix aliased crate handling in aliases attribute #3693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion rust/private/rustc.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,10 @@ def collect_deps(
else:
crate_deps.append(dep)

aliases = {k.label: v for k, v in aliases.items()}
aliases = {
k[rust_common.crate_info].owner if rust_common.crate_info in k else k.label: v
for k, v in aliases.items()
}
for dep in crate_deps:
crate_info = dep.crate_info
dep_info = dep.dep_info
Expand Down