feat(toolchain): add missing action types to toolchain configs #1611
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -target option should be added to the same actions, regardless of whether we're declaring an Xcode toolchain or a standalone toolchain. This commit brings the Linux actions up-to-date with the Xcode ones. While we're at it, we're also adding -target to the MODULEWRAP action to both Xcode and non-Xcode actions. It looks like it's ok to omit it if the target arch is the same as the host arch, but if they're different swiftc will return an error.
ma-oli
requested review from
aaronsky,
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
aaronsky
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -target option should be added to the same actions, regardless of whether we're declaring an Xcode toolchain or a standalone toolchain. This commit brings the Linux actions up-to-date with the Xcode ones.
While we're at it, we're also adding -target to the MODULEWRAP action to both Xcode and non-Xcode actions. It looks like it's ok to omit it if the target arch is the same as the host arch, but if they're different swiftc will return an error.