Skip to content

Add basic sanitizer support for swift_test #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keith merged 2 commits into from
Aug 17, 2022
Merged

Add basic sanitizer support for swift_test #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63bde23
Add basic sanitizer support for swift_test
keith Aug 15, 2022
908ff17
old method
keith Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions examples/xplatform/xctest/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,42 @@ swift_test(
"main.swift",
],
)

swift_test(
name = "xctest_tsan",
srcs = [
"SimpleTests.swift",
"main.swift",
],
features = ["tsan"],
)

swift_test(
name = "xctest_asan",
srcs = [
"SimpleTests.swift",
"main.swift",
],
features = ["asan"],
)

swift_test(
name = "xctest_ubsan",
srcs = [
"SimpleTests.swift",
"main.swift",
],
features = ["ubsan"],
)

swift_test(
name = "xctest_tsan_and_ubsan",
srcs = [
"SimpleTests.swift",
"main.swift",
],
features = [
"tsan",
"ubsan",
],
)
29 changes: 27 additions & 2 deletions tools/xctest_runner/xctest_runner.sh.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,36 @@ trap 'rm -rf "$tmp_dir"' EXIT
readonly profraw="$tmp_dir/coverage.profraw"

# Foo.xctest/Contents/MacOS/Foo -> Foo.xctest
bundle_path="$(dirname "$(dirname "$(dirname "%executable%")")")"
executable_path="%executable%"
bundle_path="$(dirname "$(dirname "$(dirname "$executable_path")")")"

sanitizer_dyld_env=""
if output=$(otool -L "$executable_path" | grep @rpath/libclang_rt | xargs | cut -d " " -f 1); then
rpath=$(otool -l "$executable_path" | grep -A2 LC_RPATH | grep "^\s*path" | grep usr/lib/clang | head -1 | cut -d " " -f 11)
if [[ -z "$rpath" ]]; then
echo "Sanitizer libraries are required but rpath could not be inferred, please file an issue" >&2
exit 1
fi

for lib in $output; do
if [[ -n "$sanitizer_dyld_env" ]]; then
sanitizer_dyld_env="$sanitizer_dyld_env:"
fi
sanitizer_dyld_env="${sanitizer_dyld_env}$rpath/${lib#@rpath/}"
done
fi

if [[ -n "${DYLD_INSERT_LIBRARIES:-}" ]]; then
if [[ -n "$sanitizer_dyld_env" ]]; then
sanitizer_dyld_env="$sanitizer_dyld_env:"
fi
sanitizer_dyld_env="$sanitizer_dyld_env$DYLD_INSERT_LIBRARIES"
fi

exit_status=0
xctest=$(xcrun -f xctest)
# TODO(allevato): Support Bazel's --test_filter.
LLVM_PROFILE_FILE="$profraw" xcrun xctest -XCTest All "$bundle_path" || exit_status=$?
DYLD_INSERT_LIBRARIES=$sanitizer_dyld_env LLVM_PROFILE_FILE="$profraw" $xctest -XCTest All "$bundle_path" || exit_status=$?

if [[ "$exit_status" -ne 0 ]]; then
exit "$exit_status"
Expand Down