Add missing swift_import params to objc_provider #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwellE
requested review from
BalestraPatrick,
brentleyjones,
keith,
segiddins and
thii
as code owners
Contributor
Author
|
@keith I would like to get a test on this, just not sure what .a file should be used here |
Member
|
does it have to be a valid one 🙃 could you create an empty file from a genrule |
Adds the missing params to the objc_provider call due to changes in bazelbuild#868 Fixes swift_import fails with "new_objc_provider() missing 2 required keyword-only arguments: is_test, swift_toolchain" bazelbuild#884
brentleyjones
force-pushed
the
maxwelle/fix_for_swift_import_params
branch
from
be684aa to
fa03d44
Compare
brentleyjones
approved these changes
Aug 30, 2022
dierksen
pushed a commit
to dierksen/rules_swift
that referenced
this pull request
Sep 6, 2022
Adds the missing params to the objc_provider call due to changes in bazelbuild#868 Fixes bazelbuild#884
dierksen
added a commit
to dierksen/rules_swift
that referenced
this pull request
Sep 6, 2022
* master: Update README with new URL (bazelbuild#893) Don't error if worker runfiles aren't present (bazelbuild#892) Supporting Swift 5.7 Bare Slash Regex Literal (bazelbuild#886) Use runfiles for `index-import` path (bazelbuild#889) Add additional outputs to the swift module in `SwiftInfo` (bazelbuild#888) Add missing swift_import params to objc_provider (bazelbuild#885) Fix typo in docs (bazelbuild#887) Update README with new URLs (bazelbuild#883) Add `apple.swizzle_absolute_xcttestsourcelocation` feature (bazelbuild#878) Require cacheable swiftmodules for -no-clang-module-breadcrumbs Update apple_support (bazelbuild#880) Add basic sanitizer support for swift_test (bazelbuild#877) Remove compatibility readme section Moves compile_outputs.symbol_graph_directory under all_derived_outputs
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
Adds the missing params to the objc_provider call due to changes in bazelbuild#868 Fixes bazelbuild#884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing params to the objc_provider call due to changes in
#868
Fixes #884