Add opt params to projectile-run-(async)-shell-cmd #1675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
The commands
async-shell-command
andshell-command
accept up to three parameters:COMMAND &OPTIONAL OUTPUT-BUFFER ERROR-BUFFER
, the commandsprojectile-run-shell-command-on-root
andprojectile-run-async-shell-command-on-root
(which call those commands above) are not callable non-interactively and can't pass the two optional parameters to the(async)-shell-command
.Solution:
Change the signature of these two functions to match the
(async)-shell-command
:M-x checkdoc
was generating some warnings before I made any change, but there were none when byte-compilingBefore submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)M-x checkdoc
warningsThanks!