Drop arduino String class at the FirebaseArduino layer.

[ed7coyne]

We will use std::string on all deeper layers, this makes testing and code sharing much easier

[bblanchon]

I'm sorry, I don't understand.
Can you be more specific?

FYI, when used outside of Arduino, String is just a typedef of std::string.
See ArduinoJson/Arduino/String.hpp, line 13

[ed7coyne]

Sorry, I am still new to github. I created the issue against the wrong project. This explains why I couldn't assign myself to it though :)

[ed7coyne]

Although since you mentioned the typdef, you may want to consider adding an ifndef guard around it, like this: https://github.com/googlesamples/firebase-arduino/blob/master/src/third-party/arduino-json-5.2/include/ArduinoJson/Arduino/String.hpp#L12

It is a somewhat common requirement to override arduino String for testing off of arduino and without this guard it makes it harder to include your library.

I think we (firebase-arduino) won't need it anymore because we are going to stop using String in any tested classes so we will drop our define but it might be nice to provide for other library users.

[bblanchon]

I think it would be better not to declare anything in the global namespace.

I can replace this by an ArduinoJson::String that would either be a typedef of std::string or Arduino's String.

What do you think?

[ed7coyne]

That sounds like a pretty clean solution. Might even steal that idea and use it on our side :)