Skip to content

Conversation

nomis
Copy link
Contributor

@nomis nomis commented Aug 10, 2019

If ARDUINO is defined then it should be safe to assume <Arduino.h> can be included (and should be, otherwise not all features work).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.485% when pulling 5c86cfa on nomis:include-Arduino.h into 63d7d87 on bblanchon:6.x.

@bblanchon
Copy link
Owner

Hi @nomis,

Thank you for this contribution.
In which situation can you have ARDUINO defined without Arduino.h?

Best Regards,
Benoit

@nomis
Copy link
Contributor Author

nomis commented Aug 11, 2019

When using PlatformIO, it defines ARDUINO on the command line.

@bblanchon bblanchon closed this in b9c4a0c Aug 12, 2019
@bblanchon
Copy link
Owner

Fix available in ArduinoJson 6.11.4

Repository owner locked and limited conversation to collaborators Sep 12, 2019
stawiski pushed a commit to stawiski/ArduinoJson that referenced this pull request Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants