This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Fix starting line number of multi-line nodes with tokens #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeaumont
suggested changes
Sep 28, 2017
|
|
||
| if node_column is None or node_column != token_startcolumn: | ||
| token_startcolumn = token[TOKEN_STARTLOC][TOKENCOL] | ||
| if nodedict.get('col_offset') != token_startcolumn: |
Contributor
There was a problem hiding this comment.
Shouldn't this be if nodedict.get('col_offset') != token_startcolumn + add: ?
If so, I don't see the point of checking the values, wouldn't it just be simpler with:
nodedict['lineno'] = token[TOKEN_STARTLOC][TOKENROW]
nodedict['col_offset'] = token[TOKEN_STARTLOC][TOKENCOL] + addAlso note that there's no consistency in strins. and both single and double quoted strings are used.
Contributor
Author
There was a problem hiding this comment.
True, the "if" was a vestige of when this code was in pydetector, I've also removed the "add" parameter that was optional an unused (another vestige).
abeaumont
approved these changes
Sep 28, 2017
juanjux
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102.
Will be rebased after #101 is merged.