Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Fix None directly visited by the main visit method #120

Merged
merged 3 commits into from
Oct 4, 2017
Merged

Fix None directly visited by the main visit method #120

merged 3 commits into from
Oct 4, 2017

Conversation

@juanjux
Copy link
Contributor

@juanjux juanjux commented Oct 4, 2017 •
edited
Loading

  • None nodes directly visited by the main visit() were crashing.
  • Rename unneeded vestigial parameter.
  • Add integration tests for issue 119 and some previous ones.

Fixes #119

@juanjux juanjux self-assigned this Oct 4, 2017
@juanjux juanjux requested a review from abeaumont October 4, 2017 13:05
Juanjo Alvarez added 2 commits October 4, 2017 15:07
Handle NoneTypes that can be found by the main visit() method
f99a03e 
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Added test for this issue and some previous ones
2ad531f 
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
@juanjux juanjux changed the title Fix None directly visited by the main visit() method instead of derived ones Fix None directly visited by the main visit method Oct 4, 2017
@juanjux juanjux mentioned this pull request Oct 4, 2017
Closed
Fixed empty integration test file.
c46ce1e 
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
@juanjux juanjux merged commit fb104a8 into bblfsh:master Oct 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@abeaumont abeaumont abeaumont approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@juanjux juanjux

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juanjux @abeaumont